linux-kernel - Re: [PATCH] madvise_need_mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29495f1d0706180951r2b7d0fe1gdcc0158011baf637@mail.gmail.com>
Date:	Mon, 18 Jun 2007 09:51:59 -0700
From:	"Nish Aravamudan" <nish.aravamudan@...il.com>
To:	"Jason Baron" <jbaron@...hat.com>
Cc:	"Christoph Hellwig" <hch@...radead.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	nickpiggin@...oo.com.au, "Rik van Riel" <riel@...hat.com>
Subject: Re: [PATCH] madvise_need_mmap_write() usage

On 6/18/07, Jason Baron <jbaron@...hat.com> wrote:
>
> On Sat, 16 Jun 2007, Christoph Hellwig wrote:
>
> > On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote:
> > > hi,
> > >
> > > i was just looking at the new madvise_need_mmap_write() call...can we
> > > avoid an extra case statement and function call as follows?
> >
> > Sounds like a good idea, but please move the assignment out of the
> > conditional.
> >
>
> ok, here's an updated version:

You should always append the full patch, both the diff and the
rationale, I think. Even though it's quoted above, might make less
work for Andrew to pull in.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/