linux-kernel - Re: [BUG] long freezes on thinkpad t60

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070618064343.GA31113@elte.hu>
Date:	Mon, 18 Jun 2007 08:43:43 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	cebbert@...hat.com, chris@...ee.ca, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org
Subject: Re: [BUG] long freezes on thinkpad t60


* Miklos Szeredi <miklos@...redi.hu> wrote:

> > could you try the quick hack below, ontop of cfs-v17? It adds two 
> > things to wait_task_inactive():
> > 
> > - a cond_resched() [in case you are running !PREEMPT]
> > 
> > - use MONITOR+MWAIT to monitor memory transactions to the rq->curr
> >   cacheline. This should make the polling loop definitely fair.
> 
> Is it not possible for the mwait to get stuck?

it is - when the other CPU does nothing.

> > If this solves the problem on your box then i'll do a proper fix and 
> > introduce a cpu_relax_memory_change(*addr) type of API to around 
> > monitor/mwait. This patch boots fine on my T60 - but i never saw 
> > your problem.
> 
> Yes, the patch does make the pauses go away.  In fact just the 
> smp_mb() seems to suffice.

cool! Could you send me the smallest patch you tried that still made the 
hangs go away?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/