linux-kernel - Re: [PATCH] create_new_namespaces: fix improper return of NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070619142730.GA27361@tv-sign.ru>
Date:	Tue, 19 Jun 2007 18:27:30 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Cedric Le Goater <clg@...ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Herbert Poetzl <herbert@...hfloor.at>, pbadari@...ibm.com,
	containers@...ts.osdl.org, ebiederm@...ssion.com, serue@...ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] create_new_namespaces: fix improper return of NULL

On 06/19, Cedric Le Goater wrote:
>
> Oleg Nesterov wrote:
> > Untested.
> > 
> > dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong,
> > create_new_namespaces() uses ERR_PTR() to catch an error. This means
> > that the subsequent create_new_namespaces() will hit BUG_ON() in
> > copy_mnt_ns() or copy_utsname().
> 
> I sent one just like it :
> 
> 	http://lkml.org/lkml/2007/6/12/142

Ah, thanks.

Your patch is more complete, it also fixes kernel/user_namespace.c (which
I don't see in 2.6.22-rc5). I don't this this fix is urgent, so...

Andrew, please ignore this patch.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/