linux-kernel - [PATCH RT] Only check IRQ Thread affinity update if CPU affinity changed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 19 Jun 2007 15:41:31 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	RT <linux-rt-users@...r.kernel.org>
Subject: [PATCH RT] Only check IRQ Thread affinity update if CPU affinity
	changed.

This patch cleans up the softirq in hardirq change. The hard irq threads
pin themselves to one of the CPUs that the IRQ affinity is on.

This patch cleans up this by only updating the cpu affinity, if the cpu
that the thread is pinned on is no longer part of the IRQ affinity.

Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

Index: linux-2.6-rt-test/kernel/irq/manage.c
===================================================================
--- linux-2.6-rt-test.orig/kernel/irq/manage.c
+++ linux-2.6-rt-test/kernel/irq/manage.c
@@ -762,13 +762,15 @@ static int do_irqd(void * __desc)
 
 #ifdef CONFIG_SMP
 	cpumask_t cpus_allowed, mask;
+	int pinned_cpu;
 
 	cpus_allowed = desc->affinity;
 	/*
 	 * Restrict it to one cpu so we avoid being migrated inside of
 	 * do_softirq_from_hardirq()
 	 */
-	mask = cpumask_of_cpu(first_cpu(desc->affinity));
+	pinned_cpu = first_cpu(desc->affinity);
+	mask = cpumask_of_cpu(pinned_cpu);
 	set_cpus_allowed(current, mask);
 #endif
 	current->flags |= PF_NOFREEZE | PF_HARDIRQ;
@@ -793,14 +795,15 @@ static int do_irqd(void * __desc)
 		/*
 		 * Did IRQ affinities change?
 		 */
-		if (!cpus_equal(cpus_allowed, desc->affinity)) {
+		if (!cpu_isset(pinned_cpu, desc->affinity)) {
 			cpus_allowed = desc->affinity;
 			/*
 			 * Restrict it to one cpu so we avoid being
 			 * migrated inside of
 			 * do_softirq_from_hardirq()
 			 */
-			mask = cpumask_of_cpu(first_cpu(desc->affinity));
+			pinned_cpu = first_cpu(desc->affinity);
+			mask = cpumask_of_cpu(pinned_cpu);
 			set_cpus_allowed(current, mask);
 		}
 #endif


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/