linux-kernel - [PATCH RT] Remove double warning print with faulty preempt disable nesting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 19 Jun 2007 16:23:47 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	RT <linux-rt-users@...r.kernel.org>
Subject: [PATCH RT] Remove double warning print with faulty preempt disable
	nesting

On a faulty preempt disable bug we print out a warning but then we go
and call preempt_enable_no_resched, which also can print out a warning.
This is redundant.

Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

Index: linux-2.6.21-rt9/lib/smp_processor_id.c
===================================================================
--- linux-2.6.21-rt9.orig/lib/smp_processor_id.c
+++ linux-2.6.21-rt9/lib/smp_processor_id.c
@@ -47,7 +47,11 @@ unsigned int notrace debug_smp_processor
 	dump_stack();
 
 out_enable:
-	preempt_enable_no_resched();
+	/*
+	 * Don't print message if we enable to zero.
+	 * We arleady printed a warning up above.
+	 */
+	__preempt_enable_no_resched();
 out:
 	return this_cpu;
 }


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/