lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070620113842.03635603@hyperion.delvare>
Date:	Wed, 20 Jun 2007 11:38:42 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Rodolfo Giometti <giometti@...eenne.com>
Cc:	Trilok Soni <soni.trilok@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>, i2c@...sensors.org,
	linux-kernel@...r.kernel.org
Subject: Re: [i2c] [PATCH] I2C: TSL2550 support.

Hi Rodolfo,

On Tue, 19 Jun 2007 16:48:46 +0200, Rodolfo Giometti wrote:
> Please, note that I left LUX calculation untouched since on my data
> sheet I have only such cumputation example. :(
> 
> Hope it could be ok anyway...

Datasheets typically give you one way to process the data, that doesn't
mean this is the only way, nor the best in all situations. My proposal
was mathematically equivalent to your datasheet-based implementation,
and had a lower memory footprint.

Anyway, your way works too, so it's OK. I'll take your patch as is,
optimizations can always be applied later. I wish I could give a try to
your driver, but unfortunately I still didn't manage to get my TAOS
evaluation module to work under Linux :(

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ