linux-kernel - Re: [RFC PATCH 4/4] Directory listing support for union mounted directories.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1182349348.6225.15.camel@heimdal.trondhjem.org>
Date:	Wed, 20 Jun 2007 10:22:28 -0400
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Bharata B Rao <bharata@...ux.vnet.ibm.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jan Blunck <j.blunck@...harburg.de>
Subject: Re: [RFC PATCH 4/4] Directory listing support for union mounted
	directories.

On Wed, 2007-06-20 at 13:09 +0100, Christoph Hellwig wrote:
> On Wed, Jun 20, 2007 at 11:24:18AM +0530, Bharata B Rao wrote:
> > From: Bharata B Rao <bharata@...ux.vnet.ibm.com>
> > Subject: Directory listing support for union mounted directories.
> > 
> > Modifies readdir()/getdents() to support union mounted directories.
> > 
> > This patch adds support to readdir()/getdents() to read directory entries
> > from all the directories of the union stack, and present a merged view to
> > the userspace. This is achieved by maintaining a cache of read entries.
> > 
> > TODO: Breaks lseek on union mounted directories, Fix this.
> 
> Btw, to avoid dealing with file structs representing multiple objects
> ->readdir should be changed to an inode_operation and not take a struct
> file * but rather struct inode + loff_t *ppos.  This sounds like a nice
> preparatory patch for any kind of union mount implementation and is
> acceptable standing on it's own.

No it shouldn't. The struct file contains other stateful information
from the open() call (such as authentication info) that needs to be
passed into readdir.

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/