linux-kernel - Re: [PATCH 11/12] pcmcia/net_pcmcia: all net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070620134435.21410ceb.randy.dunlap@oracle.com>
Date:	Wed, 20 Jun 2007 13:44:35 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"Andreas Herrmann" <andreas.herrmann3@....com>,
	jengelh@...ux01.gwdg.de
Cc:	linux-kernel@...r.kernel.org, linux-pcmcia@...ts.infradead.org
Subject: Re: [PATCH 11/12] pcmcia/net_pcmcia: all net_pcmcia modules depend
 on PCMCIA

On Wed, 20 Jun 2007 00:52:03 +0200 Andreas Herrmann wrote:

> Fix several build errors with PCMCIA=m && NET_PCMCIA=y:
> 
>    LD      .tmp_vmlinux1
>    drivers/built-in.o: In function `nmclan_release':
>    nmclan_cs.c:(.text+0x14026c): undefined reference to `pcmcia_disable_device'
>    ...
>    drivers/built-in.o: In function `exit_xirc2ps_cs':
>    xirc2ps_cs.c:(.exit.text+0x1055): undefined reference to `pcmcia_unregister_driver'
>    make: *** [.tmp_vmlinux1] Error 1

This is interesting.  This is a result of the menuconfig changes,
which made NET_PCMCIA a boolean, and then some tristates depend
on NET_PCMCIA and the boolean -> tristate dependencies aren't
specific enough.

Your fix is one way to do it.  I'd prefer to make
NET_PCMCIA a tristate instead, then let its value trickle down
to the subordinate config symbols.

This probably means that some of the other menuconfig changes
need to be audited for this "feature."


Here is my preferred patch.
~~~~~~~~~~

From: Randy Dunlap <randy.dunlap@...cle.com>

Make NET_PCMCIA a tristate symbol so that net/pcmcia drivers
are constrained to M when needed.

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 drivers/net/pcmcia/Kconfig |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

--- linux-2.6.22-rc5.orig/drivers/net/pcmcia/Kconfig
+++ linux-2.6.22-rc5/drivers/net/pcmcia/Kconfig
@@ -3,14 +3,14 @@
 #
 
 menuconfig NET_PCMCIA
-	bool "PCMCIA network device support"
+	tristate "PCMCIA network device support"
 	depends on PCMCIA
 	---help---
-	  Say Y if you would like to include support for any PCMCIA or CardBus
-	  network adapters, then say Y to the driver for your particular card
-	  below.  PCMCIA- or PC-cards are credit-card size devices often used
-	  with laptops computers; CardBus is the newer and faster version of
-	  PCMCIA.
+	  Say Y or M if you would like to include support for any PCMCIA or
+	  CardBus network adapters, then say Y or M to the driver for your
+	  particular card below.  PCMCIA- or PC-cards are credit-card size
+	  devices often used with laptops computers; CardBus is the newer
+	  and faster version of PCMCIA.
 
 	  To use your PC-cards, you will need supporting software from David
 	  Hinds' pcmcia-cs package (see the file <file:Documentation/Changes>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/