linux-kernel - Re: [PATCH 7/12] acpi: fix another compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070620084911.GO5193@alberich.amd.com>
Date:	Wed, 20 Jun 2007 10:49:11 +0200
From:	"Andreas Herrmann" <andreas.herrmann3@....com>
To:	"Len Brown" <lenb@...nel.org>
cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 7/12] acpi: fix another compile warning

On Tue, Jun 19, 2007 at 11:38:02PM -0400, Len Brown wrote:
> On Tuesday 19 June 2007 18:50, Andreas Herrmann wrote:
> > Avoid compile warning if !ACPI_BLACKLIST_YEAR
> > 
> >   CC      drivers/acpi/blacklist.o
> >   drivers/acpi/blacklist.c:76:5: warning: "CONFIG_ACPI_BLACKLIST_YEAR" is not defined
> 
> How were you able to produce a .config with CONFIG_ACPI_BLACKLIST_YEAR not defined?

Initially I used randconfig. But you can easily create it using
"make menuconfig", too.

Just do "make mrproper && make menuconfig" and now
deselect CONFIG_PM. On x86_64 ACPI keeps enabled by default.

Now additionally activate an assorted choice of laptop misc devices,
like MSI_LAPTOP, THINKPAD_ACPI etc, and you get:

...
drivers/misc/sony-laptop.c:1458: undefined reference to `ec_read'
drivers/built-in.o: In function `acpi_ec_read':
drivers/misc/thinkpad_acpi.c:247: undefined reference to `ec_read'
drivers/built-in.o: In function `acpi_ec_write':
drivers/misc/thinkpad_acpi.c:260: undefined reference to `ec_write'
drivers/built-in.o: In function `led_write':
drivers/misc/thinkpad_acpi.c:2209: undefined reference to `ec_write'
...

drivers/acpi/blacklist.c:76:5: warning: "CONFIG_ACPI_BLACKLIST_YEAR" is not defi
ned
...

drivers/acpi/bus.c: In function 'acpi_bus_get_power':
drivers/acpi/bus.c:162: warning: implicit declaration of function 'acpi_power_get_inferred_state'
...

In short, it is possible for a user to create such a configuration.
The current kconfig for acpi and those misc devices does not prevent
it.

> Can you send it to me?
> 

Attached is a configuration that I've just created with menuconfig and
not randconfig.

Regards,

Andreas

View attachment "acpi-kconfig-issues.conf" of type "text/plain" (36623 bytes)