linux-kernel - Re: build failure due to ROOT_DEV in mtd module (was Re: linux-2.6.22-rc5-g7c8545e build #298 failed ...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Jun 2007 13:43:05 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Christoph Hellwig" <hch@...radead.org>,
	"Satyam Sharma" <satyam.sharma@...il.com>,
	"Tom Spink" <tspink@...il.com>,
	"Toralf F?rster" <toralf.foerster@....de>,
	linux-kernel@...r.kernel.org,
	"Paolo Giarrusso" <blaisorblade@...oo.it>,
	"David Woodhouse" <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org
Subject: Re: build failure due to ROOT_DEV in mtd module (was Re: linux-2.6.22-rc5-g7c8545e build #298 failed ...)

On 6/21/07, Christoph Hellwig <hch@...radead.org> wrote:
> On Thu, Jun 21, 2007 at 12:22:01PM +0530, Satyam Sharma wrote:
> > >> The build seems to fail because of:
> > >> ERROR: "ROOT_DEV" [drivers/mtd/maps/nettel.ko] undefined!
> > >>
> > >> After taking a quick look at the code, I can't immediately see why
> > >> this would be, since there is an include for linux/root_dev.h at the
> > >> top, there.
> > >>
> > >> There's only one occurrence of ROOT_DEV (line 425), and after a quick
> > >> look at the git history, it seems the include was originally missing,
> > >> but was put back in, in commit
> > >> 6cc449c7d0292cb9b993f0df84fd3225e3099492.
>
> Please just the reference to ROOT_DEV from this driver.  Just because
> someone builds this driver there should be no change in the default root
> device.

I agree, but this (drivers/mtd/maps/nettel.c) isn't the only modular driver
referencing ROOT_DEV. We also have drivers/mtd/maps/pmcmsp-ramroot.c
using ROOT_DEV (in fact the purpose of that driver seems to be precisely
to special-case the root fs and do something with it ...) but considering
that other driver's (tristate) Kconfig option depends on another symbol that
is non-existent in the mainline tree, there is no way someone can build
pmcmsp-ramroot and so we'll never actually  hit that problem even with an
allmodconfig build.

Anyway, I'll leave this up to David / linux-mtd to sort out. [ No other
modular user of ROOT_DEV in the tree other than the two mtd drivers
mentioned here. ]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/