[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070621140039.GX24544@erda.amd.com>
Date: Thu, 21 Jun 2007 16:00:39 +0200
From: "Robert Richter" <robert.richter@....com>
To: "David Rientjes" <rientjes@...gle.com>
cc: "Stephane Eranian" <eranian@....hp.com>,
"Andi Kleen" <andi@...stfloor.org>, linux-kernel@...r.kernel.org
Subject: Re: [patch 7/8] 2.6.22-rc3 perfmon2 : Renaming *_k8_* symbols
to *_amd64_*
On 20.06.07 12:43:59, David Rientjes wrote:
> On Wed, 20 Jun 2007, Robert Richter wrote:
>
> > This patch renames *_k8_* symbols to *_amd64_*.
> >
> > Signed-off-by: Robert Richter <robert.richter@....com>
> >
> > Index: linux-2.6.22-rc3/arch/x86_64/perfmon/perfmon_k8.c
> > ===================================================================
> > --- linux-2.6.22-rc3.orig/arch/x86_64/perfmon/perfmon_k8.c
> > +++ linux-2.6.22-rc3/arch/x86_64/perfmon/perfmon_k8.c
> > @@ -36,7 +36,7 @@ static int force_nmi;
> > MODULE_PARM_DESC(force_nmi, "bool: force use of NMI for PMU interrupt");
> > module_param(force_nmi, bool, 0600);
> >
> > -static struct pfm_arch_pmu_info pfm_k8_pmu_info = {
> > +static struct pfm_arch_pmu_info pfm_amd64_pmu_info = {
> > .pmc_addrs = {
> > /* pmc0 */ {{MSR_K7_EVNTSEL0, 0}, 0, PFM_REGT_EN},
> > /* pmc1 */ {{MSR_K7_EVNTSEL1, 0}, 1, PFM_REGT_EN},
> > @@ -96,7 +96,7 @@ static struct pfm_arch_pmu_info pfm_k8_p
> > #define PFM_AMD64_IBSOPCTL_NO64 PFM_AMD64_IBSOPEN
> > #define PFM_AMD64_IBSOPCTL_RSVD (~((1ULL<<16)-1))
> >
> > -static struct pfm_reg_desc pfm_k8_pmc_desc[]={
> > +static struct pfm_reg_desc pfm_amd64_pmc_desc[]={
> > /* pmc0 */ PMC_D(PFM_REG_I64, "PERFSEL0", PFM_K8_VAL, PFM_K8_RSVD, PFM_K8_NO64, MSR_K7_EVNTSEL0),
> > /* pmc1 */ PMC_D(PFM_REG_I64, "PERFSEL1", PFM_K8_VAL, PFM_K8_RSVD, PFM_K8_NO64, MSR_K7_EVNTSEL1),
> > /* pmc2 */ PMC_D(PFM_REG_I64, "PERFSEL2", PFM_K8_VAL, PFM_K8_RSVD, PFM_K8_NO64, MSR_K7_EVNTSEL2),
>
> Please fix the spacing here while you're at it. Thanks for doing it in
> the other patches in this series.
>
>
Fixed in patch version 3.
-Robert
--
AMD Saxony, Dresden, Germany
Operating System Research Center
email: robert.richter@....com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists