[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200706211654.31463.marc.pignat@hevs.ch>
Date: Thu, 21 Jun 2007 16:54:30 +0200
From: Marc Pignat <marc.pignat@...s.ch>
To: Nicolas Ferre <nicolas.ferre@....atmel.com>
Cc: ARM Linux Mailing List <linux-arm-kernel@...ts.arm.linux.org.uk>,
Linux Kernel list <linux-kernel@...r.kernel.org>,
Andrew Victor <andrew@...people.com>,
Pierre Ossman <drzeus@...eus.cx>
Subject: Re: Oops in a driver while using SLUB as a SLAB allocator
Hello Nicolas!
Good news!
I think I've found the problem, this seems to work (tested with SLUB and SLAB).
If you're in the cleanup stage, I think the whole kmap and kunmap can be in the 'if (cpu_is_at91rm9200())',
we have no reason to kmap data we don't touch :-D
Regards
Marc
--- drivers/mmc/host/at91_mci.c-2.6.22-rc5.orig 2007-06-21 16:27:31.000000000 +0200
+++ drivers/mmc/host/at91_mci.c-2.6.22-rc5 2007-06-21 16:42:48.000000000 +0200
@@ -164,7 +164,7 @@ static inline void at91mci_sg_to_dma(str
else
memcpy(dmabuf, sgbuffer, amount);
- kunmap_atomic(sgbuffer, KM_BIO_SRC_IRQ);
+ kunmap_atomic(sgbuffer - sg->offset, KM_BIO_SRC_IRQ);
if (size == 0)
break;
@@ -293,7 +293,7 @@ static void at91mci_post_dma_read(struct
buffer[index] = swab32(buffer[index]);
}
- kunmap_atomic(buffer, KM_BIO_SRC_IRQ);
+ kunmap_atomic(buffer - sg->buffer, KM_BIO_SRC_IRQ);
flush_dcache_page(sg->page);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists