[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.LFD.0.98.0706210902380.3593@woody.linux-foundation.org>
Date: Thu, 21 Jun 2007 09:03:36 -0700 (PDT)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Andi Kleen <ak@...e.de>
cc: Dave Jones <davej@...hat.com>,
Ian McDonald <ian.mcdonald@...di.co.nz>,
Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>,
Miklos Szeredi <miklos@...redi.hu>,
Ingo Molnar <mingo@...e.hu>,
"Darrick J. Wong" <djwong@...ibm.com>,
Bj?rn Steinbrink <B.Steinbrink@....de>,
William Cohen <wcohen@...hat.com>,
"S. P. Prasanna" <prasanna@...ibm.com>,
Antonino Daplas <adaplas@...il.com>,
Olaf Hering <olaf@...fle.de>, Ville Syrj?l? <syrjala@....fi>,
Jean Delvare <khali@...ux-fr.org>,
Rudolf Marek <r.marek@...embler.cz>,
Soeren Sonnenburg <kernel@....de>,
Michal Piotrowski <michal.k.k.piotrowski@...il.com>
Subject: Re: [PATCH] Alternative fix for kprobes&DEBUG_RODATA was Re: [1/2]
2.6.22-rc5: known regressions with patches
On Thu, 21 Jun 2007, Andi Kleen wrote:
> Ok, here's a patch to do this. With that 55181000cd60334fe920c65ffbcdfe0e3f1de406
> should be reverted because it isn't needed anymore.
This seems buggy:
> + int notext = 0;
>
> +#ifdef CONFIG_KPROBES
> + notext = 1;
> +#endif
> #ifdef CONFIG_HOTPLUG_CPU
> /* It must still be possible to apply SMP alternatives. */
> - if (num_possible_cpus() <= 1)
> + notext = (num_possible_cpus() > 1);
> #endif
The CONFIG_HOTPLUG_CPU case will overwrite the CONFIG_KPROBES, and turn it
back to zero for a single CPU.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists