linux-kernel - Re: [PATCH 19/19] ide: use PIO/MMIO operations directly where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <467AB253.8010902@ru.mvista.com>
Date:	Thu, 21 Jun 2007 21:16:03 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/19] ide: use PIO/MMIO operations directly where possible

Hello.

Bartlomiej Zolnierkiewicz wrote:
> [PATCH] ide: use PIO/MMIO operations directly where possible

> This results in smaller/faster/simpler code and allows future optimizations.
> Also remove no longer needed ide[_mm]_{inl,outl}() and ide_hwif_t.{INL,OUTL}.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

> Index: a/drivers/ide/pci/hpt366.c
> ===================================================================
> --- a.orig/drivers/ide/pci/hpt366.c
> +++ a/drivers/ide/pci/hpt366.c
> @@ -836,7 +836,7 @@ static int hpt374_ide_dma_test_irq(ide_d
>  		return 0;
>  	}
>  
> -	dma_stat = hwif->INB(hwif->dma_status);
> +	dma_stat = inb(hwif->dma_status);
>  	/* return 1 if INTR asserted */
>  	if (dma_stat & 4)
>  		return 1;

    Hmm... this driver *still* has a lot more indirect I/O accessors -- I 
wonder why only this one had been converted then?

MBR, Sergei

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/