linux-kernel - Re: [31/37] Large blocksize support: Core piece

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Jun 2007 22:26:27 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Bob Picco <bob.picco@...com>
cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@....de>, Mel Gorman <mel@...net.ie>,
	William Lee Irwin III <wli@...omorphy.com>,
	David Chinner <dgc@....com>,
	Jens Axboe <jens.axboe@...cle.com>,
	Badari Pulavarty <pbadari@...il.com>,
	Maxim Levitsky <maximlevitsky@...il.com>
Subject: Re: [31/37] Large blocksize support: Core piece

On Wed, 20 Jun 2007, Bob Picco wrote:

> > +	if (size > (PAGE_SIZE << MAX_ORDER) || size < 512 ||
> > +						!is_power_of_2(size))
> I think this should be:
> 	if (size > (MAX_ORDER_NR_PAGES << PAGE_SHIFT) ... 
> 	or
> 	if (size > (PAGE_SIZE << (MAX_ORDER - 1)) ...
> bob
> >  		return -EINVAL;


Right.... MAX_ORDER is the first illegal order not the last usable.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/