linux-kernel - build failure due to ROOT_DEV in mtd module (was Re: linux-2.6.22-rc5-g7c8545e build #298 failed ...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0706202352u1efed48fo5a101f8c015638d7@mail.gmail.com>
Date:	Thu, 21 Jun 2007 12:22:01 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Tom Spink" <tspink@...il.com>
Cc:	"Toralf Förster" <toralf.foerster@....de>,
	linux-kernel@...r.kernel.org,
	"Christoph Hellwig" <hch@...radead.org>,
	"Paolo Giarrusso" <blaisorblade@...oo.it>,
	"David Woodhouse" <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org
Subject: build failure due to ROOT_DEV in mtd module (was Re: linux-2.6.22-rc5-g7c8545e build #298 failed ...)

Hi,

[Added Christoph, Paolo, David and linux-mtd.]

On 6/21/07, Tom Spink <tspink@...il.com> wrote:
> On 20/06/07, Tom Spink <tspink@...il.com> wrote:
> > On 20/06/07, Toralf Förster <toralf.foerster@....de> wrote:
> > > Hello,
> > >
> > > the build with the attached .config failed, make ends with:
> > [...]
> > The build seems to fail because of:
> > ERROR: "ROOT_DEV" [drivers/mtd/maps/nettel.ko] undefined!
> >
> > After taking a quick look at the code, I can't immediately see why
> > this would be, since there is an include for linux/root_dev.h at the
> > top, there.
> >
> > There's only one occurrence of ROOT_DEV (line 425), and after a quick
> > look at the git history, it seems the include was originally missing,
> > but was put back in, in commit
> > 6cc449c7d0292cb9b993f0df84fd3225e3099492.
> [...]
> After further inspection, I *think* it's because nettel is being built
> as a module, and it's trying to reference ROOT_DEV, which is not
> exported.

You're right. Look at:
commit a2d2b5cb8e5d8787f009eeb3bbca52687bd42a77
[ http://lkml.org/lkml/2005/7/13/166 ]

You could export ROOT_DEV to modules back again, or perhaps:
http://www.infradead.org/pipermail/linux-mtd/2005-March/012290.html
to get around the build error.

[ It might've been unexported for good reasons, of course, see:
http://lkml.org/lkml/2005/3/30/179 ]

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/