linux-kernel - Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jun 2007 10:22:46 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Roman Zippel <zippel@...ux-m68k.org>
Cc:	Oliver Neukum <oneukum@...e.de>,
	linux-usb-devel@...ts.sourceforge.net, video4linux-list@...hat.com,
	Toralf Förster <toralf.foerster@....de>,
	luca.risolia@...dio.unibo.it,
	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Kconfig troubles when using menuconfig - Was: [patch]Re:
	[linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in
	zc0301_core.c

Hi Roman,

Several instabilities on Kconfig started to happen after replacing
Kconfig menus to use menuconfig, as this one, reported by Oliver:

Em Qui, 2007-06-21 às 13:50 +0200, Oliver Neukum escreveu:
> Am Donnerstag, 21. Juni 2007 schrieb Toralf Förster:
> > Right, but IMHO this issue is typical for a problem with the Kconfig definitions of this module.
> > 
> > I'll set USB devs as Cc: therefore.
> 
> The Kconfig there is incomplete.
> Mauro, please apply.
> 
> 	Regards
> 		Oliver
> Signed-off-by: Oliver Neukum <oneukum@...e.de>
>
> --- a/drivers/media/video/zc0301/Kconfig        2007-06-21 13:44:14.000000000 +0200
> +++ b/drivers/media/video/zc0301/Kconfig        2007-06-21 13:44:33.000000000 +0200
> @@ -1,6 +1,6 @@
>  config USB_ZC0301
>         tristate "USB ZC0301[P] Image Processor and Control Chip support"
> -       depends on VIDEO_V4L1
> +       depends on VIDEO_V4L1 && USB
>         ---help---
>           Say Y here if you want support for cameras based on the ZC0301 or
>           ZC0301P Image Processors and Control Chips.
> 

In this specific case, all V4L USB drivers depends on V4L_USB_DRIVERS,
that depends, in turn, on USB. So, if USB is not selected,
V4L_USB_DRIVERS should be unselected, unselecting zc0301.

Unfortunately, the Kernel building system is not properly handling it.

This is the (snipped) media/video/Kconfig:

menuconfig V4L_USB_DRIVERS
        bool "V4L USB devices"
        depends on USB
        default y

if V4L_USB_DRIVERS

source "drivers/media/video/pvrusb2/Kconfig"

<snip/>

source "drivers/media/video/zc0301/Kconfig"

<snip/>

endif # V4L_USB_DRIVERS

-- 
Cheers,
Mauro

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/