linux-kernel - Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0706221711320.26568@fbirervta.pbzchgretzou.qr>
Date:	Fri, 22 Jun 2007 17:18:24 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Roman Zippel <zippel@...ux-m68k.org>
cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Oliver Neukum <oneukum@...e.de>,
	linux-usb-devel@...ts.sourceforge.net, video4linux-list@...hat.com,
	Toralf Förster <toralf.foerster@....de>,
	luca.risolia@...dio.unibo.it, LKML <linux-kernel@...r.kernel.org>
Subject: Re: Kconfig troubles when using menuconfig - Was: [patch]Re:
 [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c


On Jun 22 2007 16:27, Roman Zippel wrote:
>
>> In this specific case, all V4L USB drivers depends on V4L_USB_DRIVERS,
>> that depends, in turn, on USB. So, if USB is not selected,
>> V4L_USB_DRIVERS should be unselected, unselecting zc0301.
>> 
>> Unfortunately, the Kernel building system is not properly handling it.
>> 
>> This is the (snipped) media/video/Kconfig:
>> 
>> menuconfig V4L_USB_DRIVERS
>>         bool "V4L USB devices"
>>         depends on USB
>>         default y
>> 
>
>The menuconfig patches were a little aggressive here, it created a config 
>symbol where there was none before and in this case it even changed 
>dependencies (it turns USB into a bool).

V4L_USB_DRIVERS=y turns USB into =y? That can't be. It should give the "this
depends on another symbol [USB] that is modular".

>I'm also a little irritated by the "default y", if I enable V4L I'm very 
>tempted to check what other useless stuff has been automatically enabled, 
>which I have to turn off again.

The default y only applies to the "menu" folders, not actual code.
There have been discussions to remove the default-ys again, I've sent a patch
[http://lkml.org/lkml/2007/5/12/216], but nothing happened.


So, should all affected menuconfigs be transformed into tristates, what 
do you think, Roman? Let me know so I can cook up a patch (hopefully 
before 2.6.22) should they become tristate.


Thanks,
	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/