linux-kernel - Re: [PATCH] update checkpatch.pl to version 0.06

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1182532151.26162.45.camel@localhost>
Date:	Fri, 22 Jun 2007 10:09:11 -0700
From:	Dave Hansen <hansendc@...ibm.com>
To:	Andy Whitcroft <apw@...dowen.org>
Cc:	Andrew Morton <akpm@...l.org>, Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.06

Andy and Joel, very cool that you got this in-tree!

I have a patch touching a bunch of fs ioctl functions.

Things like ext2_ioctl() look like this:

foo_ioctl()
{
	switch(ioctl) {
	case FOO:
		lots
		of
		code
	error:
		return result;
	case BAR:
		return result;
}

Notice that the "error:" label is indented.  Each of the case is kinda
like a mini function with its own variables and return statement.

Do you think it is worth teaching the patch checker about these?  It
seems pretty sane style to me.

Would we want to teach it that labels must be inside of brackets, or
should we have it look at the whole file to see if there precedent for
indented labels in the file?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/