linux-kernel - Re: [PATCH] update checkpatch.pl to version 0.06

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1182535330.26162.50.camel@localhost>
Date:	Fri, 22 Jun 2007 11:02:10 -0700
From:	Dave Hansen <hansendc@...ibm.com>
To:	Joel Schopp <jschopp@...tin.ibm.com>
Cc:	Andy Whitcroft <apw@...dowen.org>, Andrew Morton <akpm@...l.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.06

On Fri, 2007-06-22 at 12:54 -0500, Joel Schopp wrote:
> If it is "kinda like a mini function" why not make it "actually a mini
> function" and call it? 

Several of our on-disk filesystems have an ioctl function that already
has indented goto labels.  I don't think it's quite worth churning all
of these (working) filesystems to make a style checker happy.

I think it's worse style to be mixing label indentation in a file as it
is to create new "correct" indentation labels.  That's why I suggested
using context in the file to determine it rather than absolute rules.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/