linux-kernel - Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0706221420u6935e75er1ee5601e013b40d2@mail.gmail.com>
Date:	Sat, 23 Jun 2007 02:50:25 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Trent Piepho" <xyzzy@...akeasy.org>
Cc:	"Mauro Carvalho Chehab" <mchehab@...radead.org>,
	"Roman Zippel" <zippel@...ux-m68k.org>,
	"Linux and Kernel Video" <video4linux-list@...hat.com>,
	linux-usb-devel@...ts.sourceforge.net, toralf.foerster@....de,
	"Oliver Neukum" <oneukum@...e.de>,
	LKML <linux-kernel@...r.kernel.org>,
	"Jan Engelhardt" <jengelh@...ux01.gwdg.de>,
	"Luca Risolia" <luca.risolia@...dio.unibo.it>
Subject: Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

Hi Trent,

On 6/23/07, Trent Piepho <xyzzy@...akeasy.org> wrote:
> [...]
> What you have is tristate depends on bool depends on tristate.  The bool
> between the two tristates "promotes" the first tristate from m to y.
> [...]
> Or another way, add the dependencies of the menuconfig to the if statement:
> diff -r dfbe7cc4e21e drivers/media/video/Kconfig
> --- a/drivers/media/video/Kconfig       Thu Jun 21 16:02:50 2007 -0700
> +++ b/drivers/media/video/Kconfig       Fri Jun 22 13:10:43 2007 -0700
> @@ -691,7 +691,7 @@ menuconfig V4L_USB_DRIVERS
>         depends on USB
>         default y
>
> -if V4L_USB_DRIVERS
> +if V4L_USB_DRIVERS && USB
>
>  source "drivers/media/video/pvrusb2/Kconfig"
>
> Now all the usb drivers will gain USB as a dependency directly and can't be
> set to something higher than USB.

Ok, so we add this as solution 2.(c) to the reply I just sent to Jan :-)

But I still prefer 2.(b) -- making the config scripts intelligent so that if a
given "menuconfig FOO depends on BAR", then all the "config BAZ"s
inside this menuconfig also automatically "depend on" BAR too.
This is simpler in the long run because it requires least amount
(actually none) of redundant typing and would continue to work in
the future if/when the:

menuconfig FOO
if FOO
...
endif # FOO

idiom is converted to an:

configmenu FOO
...
endconfigmenu # FOO

kind of idiom ...

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/