The cpuidle patches moved the tick nohz handling from irq_exit into the inner idle loop. The change is correct as it covers non interrupt based wakeups (e.g DMA) on x86 as well, but the move breaks ARM, SH and SPARC64. Keep the original implementation and deselet the irq exit code for those architectures which have idle wakeups without interrupts. This way the non affected architectures are not burdened with the extra changes in the idle implementation. Signed-off-by: Thomas Gleixner Cc: Adam Belay Cc: Len Brown Cc: Dave Miller Cc: Paul Mundt Cc: Russell King --- arch/i386/Kconfig | 4 ++++ kernel/softirq.c | 5 +++++ 2 files changed, 9 insertions(+) Index: linux-2.6.22-rc4-mm/arch/i386/Kconfig =================================================================== --- linux-2.6.22-rc4-mm.orig/arch/i386/Kconfig 2007-06-23 14:38:57.000000000 +0200 +++ linux-2.6.22-rc4-mm/arch/i386/Kconfig 2007-06-23 14:38:57.000000000 +0200 @@ -31,6 +31,10 @@ config GENERIC_CLOCKEVENTS_BROADCAST default y depends on X86_LOCAL_APIC +config NONIRQ_WAKEUP + bool + default y + config LOCKDEP_SUPPORT bool default y Index: linux-2.6.22-rc4-mm/kernel/softirq.c =================================================================== --- linux-2.6.22-rc4-mm.orig/kernel/softirq.c 2007-06-23 14:38:57.000000000 +0200 +++ linux-2.6.22-rc4-mm/kernel/softirq.c 2007-06-23 14:38:57.000000000 +0200 @@ -304,6 +304,11 @@ void irq_exit(void) if (!in_interrupt() && local_softirq_pending()) invoke_softirq(); +#if defined(CONFIG_NO_HZ) && !defined(CONFIG_NONIRQ_WAKEUP) + /* Make sure that timer wheel updates are propagated */ + if (!in_interrupt() && idle_cpu(smp_processor_id()) && !need_resched()) + tick_nohz_stop_sched_tick(); +#endif preempt_enable_no_resched(); } -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/