linux-kernel - RE: [PATCH -rt] Preemption problem in kernel RT Patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77B279EC7347F341A6AE891AA6AD68E9314252@ranchero.sycamorenet.com>
Date:	Sat, 23 Jun 2007 10:08:06 -0400
From:	"Beauchemin, Mark" <Mark.Beauchemin@...amorenet.com>
To:	"Thomas Gleixner" <tglx@...utronix.de>
Cc:	<linux-kernel@...r.kernel.org>, <mingo@...e.hu>,
	"David Miller" <davem@...emloft.net>
Subject: RE: [PATCH -rt] Preemption problem in kernel RT Patch

Thomas,


> please fix your mail client to do proper line wraps at column 78.

	Outlook sucks.  I'll install thunderbird this weekend.  sorry.

> Nice, but nevertheless wrong theory.
> 
> This check is part of the RT-Patch and it _is_ entirely correct: 
> Something tries to do a spin_lock() on a lock, which the same task has
> already locked before. That's what the BUG_ON is catching.
>
> There is nothing which can make a task magically the owner of a lock,
> whether preemption is enabled or not.

	Thanks for straightening me out.  I was reading the function 
try_to_take_rt_mutex wrong...  The problem makes more sense now.  The tunnel 
code encapsulates the current packet in a new packet and calls ip_output 
to get it to the destination.  If the routing table is changing(which 
I'm doing when this happens) it could be called recursively.  The tunnel
code tries to handle recursion at the top of ipip_tunnel_xmit:

	if (tunnel->recursion++) {
		tunnel->stat.collisions++;
		goto tx_error;
	} 

	The problem is it tries to take dev->lock which it already owns in 
dev_queue_xmit before the check for recursion.

	Unfortunately, every time I put in debug to see the routing 
changes which cause the bug, it doesn't happen.  I'll certainly try to 
reproduce it with CONFIG_PROVE_LOCKING on, but it won't be till end of next 
week as we have a release going out.

	Thanks for your help,

		Mark Beauchemin





-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/