linux-kernel - Re: [patch] 2.6.22-rc Kconfig troubles when using menuconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1182637586.10174.36.camel@gaivota>
Date:	Sat, 23 Jun 2007 19:26:26 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux and Kernel Video <video4linux-list@...hat.com>,
	Toralf Förster <toralf.foerster@....de>,
	Luca Risolia <luca.risolia@...dio.unibo.it>,
	LKML <linux-kernel@...r.kernel.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	Satyam Sharma <satyam.sharma@...il.com>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Oliver Neukum <oneukum@...e.de>,
	Trent Piepho <xyzzy@...akeasy.org>
Subject: Re: [patch] 2.6.22-rc Kconfig troubles when using menuconfig

Hi Jan,



Your patch seems OK to me, providing that we also add the Andreas patch:

---

Correct Kconfig to avoid compile errors like
    
 drivers/built-in.o: In function `sn9c102_usb_disconnect':
 sn9c102_core.c:(.text+0x8d840): undefined reference to `usb_get_dev'
    
Signed-off-by: Andreas Herrmann <andreas.herrmann3@....com>

diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 4cca551..4754d98 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -687,7 +687,7 @@ config VIDEO_CAFE_CCIC
 #
 
 menuconfig V4L_USB_DRIVERS
-	bool "V4L USB devices"
+	tristate "V4L USB devices"
 	depends on USB
 	default y
 

Em Sáb, 2007-06-23 às 09:20 +0200, Jan Engelhardt escreveu:
> Anyone with strong objections to this patch? (Hopefully) fixes the 
> kconfig issue for now.
> 
> 
> Signed-off-by: Jan Engelhardt <jengelh@....de>
Acked-by: Mauro Carvalho Chehab <mchehab@...radead.org>
	(for both Andreas and your patch)

-- 
Cheers,
Mauro

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/