linux-kernel - Re: [PATCH] ALSA: use __devexit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Jun 2007 18:50:57 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	perex@...e.cz
CC:	Randy Dunlap <randy.dunlap@...cle.com>,
	akpm <akpm@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: use __devexit_p

This reminds me...

Someone needs to go through ALSA and audit all delays executed via 
$FOO_interruptible().

Several delays within ALSA wait for hardware conditions, and do not 
check for signals pending, which means that the wait-for-condition loop 
becomes a busy loop:

	while (1) {
		foo = read_hardware()
		if (foo & interesting_bits)
			break;
		schedule_timeout_interruptible(1);
	}

The proper fix is (a) remove "_interruptible" [recommended] or (b) check 
for signals.

grep'ing for "_interruptible" quickly finds several such ALSA bugs.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/