linux-kernel - Re: [PATCH] x86-64: disable the GART in shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070623110928.GF4441@rhun.cust.hotspot.t-mobile.com>
Date:	Sat, 23 Jun 2007 04:09:28 -0700
From:	Muli Ben-Yehuda <muli@...ibm.com>
To:	Andi Kleen <ak@...e.de>
Cc:	Yinghai Lu <Yinghai.Lu@....com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Vivek Goyal <vgoyal@...ibm.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86-64: disable the GART in shutdown

On Sat, Jun 23, 2007 at 12:59:17PM +0200, Andi Kleen wrote:
> 
> > I'm going to need exactly the same hook fro Calgary, as well Intel for
> > VT-d, and AMD for their upcoming IOMMU, etc. How about we do
> > 
> > struct iommu_ops {
> >   struct dma_ops {
> >     ...
> >   }
> >   void (*shutdown)(void);
> > }
> > 
> > And then pci_iommu_shutdown() becomes
> > 
> > if (iommu_ops->shutdown)
> >   iommu_ops->shutdown();
> 
> I think it's cleaner if everybody registers their own shutdown
> handler in sysfs Don't see any value in going through a generic
> layer because there is no shared code.

Going through the shared layer makes it obvious to new IOMMU
implementers that they will need to implement a shutdown hook and
takes roughly the same ammount of work. I think that's a net win.

Cheers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/