linux-kernel - Re: [RFC] [PATCH 2.6.21.5] ppp: fix osize too small errors when decoding mppe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070623.230702.60547745.davem@davemloft.net>
Date:	Sat, 23 Jun 2007 23:07:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	konstantin.sharlaimov@...il.com
Cc:	paulus@...ba.org, vsu@...linux.ru, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] [PATCH 2.6.21.5] ppp: fix osize too small errors when
 decoding mppe

From: Konstantin Sharlaimov <konstantin.sharlaimov@...il.com>
Date: Wed, 20 Jun 2007 22:37:18 +1100

> The mppe_decompress() function required a buffer that is 1 byte too small when
> receiving a message of mru size. This fixes buffer allocation to prevent this
> from occurring.
> 
> Signed-off-by: Konstantin Sharlaimov <konstantin.sharlaimov@...il.com>

This looks better, I've reverted the original version of the
fix and applied this new one.

> --- linux-2.6.21.3/drivers/net/ppp_generic.c.orig	2007-06-20 09:14:13.000000000
> +1100
> +++ linux-2.6.21.3/drivers/net/ppp_generic.c	2007-06-20 09:18:06.000000000 +1100

Please prevent your email client from corrupting patches like
this by adding new lines.

I've fixed up your patches by hand now twice, I'm not going to do it
any more.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/