linux-kernel - Re: [PATCH]is_power_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0706250826300.4499@localhost.localdomain>
Date:	Mon, 25 Jun 2007 08:27:42 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Johannes Weiner <hannes-kernel@...urebad.de>
cc:	vignesh babu <vignesh.babu@...ro.com>, daniel.pirkl@...il.cz,
	dushistov@...l.ru, linux-kernel <linux-kernel@...r.kernel.org>,
	Kernel Janitors List <kernel-janitors@...ts.osdl.org>
Subject: Re: [PATCH]is_power_of_2-ufs/super.c

On Mon, 25 Jun 2007, Johannes Weiner wrote:

> Hi,
>
> On Thu, Jun 14, 2007 at 01:39:18PM +0530, vignesh babu wrote:
> > Replacing (n & (n-1)) in the context of power of 2 checks
> > with is_power_of_2
>
> You might want to run
>
> 	egrep -R '([a-zA-Z0-9_.>]+) *& *\(\1 *- *1\)' /usr/src/linux
>
> This does not match if the check is broken into multiple lines,
> though. Still, 66 matches so far. Perhaps a big patch that removes
> most of these occurrences would be more appropriate.

this cleanup project is already well documented here:

http://fsdev.net/wiki/index.php?title=Power_of_2_stuff

and it's unlikely that you'd get a big patch in that tries to do all
of that at once.  it's much easier to do it a subsystem at a time.

rday

p.s.  that wiki page could probably use some updating.

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/