linux-kernel - Re: [PATCH 1/1] fs-sysfs bugfix of sysfs_hash_and_remove dereferencing before checking for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070625212543.GB13415@kroah.com>
Date:	Mon, 25 Jun 2007 14:25:43 -0700
From:	Greg KH <greg@...ah.com>
To:	dougthompson@...ssion.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] fs-sysfs bugfix of sysfs_hash_and_remove
	dereferencing before checking for NULL

On Fri, Jun 22, 2007 at 10:13:24AM -0700, Doug Thompson wrote:
> From:	Douglas Thompson <dougthompson@...ssion.com>
> 
> In tracking down one of my bugs in using sysfs, I found the kernel doing a NULL de-reference
> in function fs/sysfs/inode.c:sysfs_hash_and_remove(), when I (incorrectly) passed
> in a dentry value of NULL.
> 
> The check for NULL should occur BEFORE the dereference of 'dir'. 
> This patch modifies the sequence and does the check FIRST
> 
> 
> Signed-off-by:	Douglas Thompson <dougthompson@...ssion.com>
> ---
> 
> Index: linux-2.6.22-rc4-mm2/fs/sysfs/inode.c

There's been a lot of churn and change in this area and this patch
doens't apply anymore.  Can you try respinning it against the next -mm
release and resending it if it is still needed?

thanks,

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/