linux-kernel - Re: [PATCH] Fix headers_install for x86-64 (now with less whitespace damage!)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200706261048.41738.rob@landley.net>
Date:	Tue, 26 Jun 2007 10:48:41 -0400
From:	Rob Landley <rob@...dley.net>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix headers_install for x86-64 (now with less whitespace damage!)

On Tuesday 26 June 2007 10:03:49 David Woodhouse wrote:
> On Tue, 2007-06-26 at 09:12 -0400, Rob Landley wrote:
> > Signed-off-by: Rob Landley <rob@...dley.net>
> >
> >  A bug in headers_install for ARCH=x86_64 yields an asm/ directory full
> > of files all of which are using the same #ifdef guard, "__ASM_STUB_" with
> > no postfix. So the second and later asm files #included in the same C
> > file (often through standard headers like ioctl.h) yields no symbols.
>
> Interesting. It works here with bash 3.2 -- I thought it was the _first_ 
> shell which expanded $FNAME and $STUBDEF inside the parentheses. Which
> shell are you using?

Stock Ubuntu 7.04 comes with /bin/sh pointing to the Dumb-Ass SHell.  (Motto: 
If it's not explicitly mentioned in posix, and we accidentally support it, 
let us know so we can remove it!)

> Is it sufficient just to add the missing semicolon after FNAME=...?

Huh.  Apparently, yes it is.  (I thought I'd tried that and it hadn't worked, 
but I just tried it again and it worked, so ok.  It's before noon, don't 
expect accuracy from me yet today...)

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/