linux-kernel - Re: [PATCH] LinuxPPS (with new syscalls API)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1182882046.3263.24.camel@shinybook.infradead.org>
Date:	Tue, 26 Jun 2007 19:20:46 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Rodolfo Giometti <giometti@...eenne.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] LinuxPPS (with new syscalls API)

On Tue, 2007-06-26 at 20:13 +0200, Rodolfo Giometti wrote:
> On Tue, Jun 26, 2007 at 06:38:40PM +0100, David Woodhouse wrote:
> 
> > That sounds like you're scared of using goto. Don't be :)
> 
> But it's not wrong... should I change it or not?

I would suggest changing it. It makes it more obvious to the casual that
there are no other callers of the 'internal' functions. It's a matter of
taste though; if you feel _very_ strongly about it then feel free to
ignore me.

> Is this right?
> +unifdef-y += pps.h

Yes, that looks right. As a matter of course you should also run 'make
headers_check' before submitting your new patch, to make sure everything
is sane. That'll tell you if your exported pps.h is trying to include
other header files which aren't also exported.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/