linux-kernel - Re: [PATCH 2/5] piix: backport short cables support from ata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46815B44.1040609@ru.mvista.com>
Date:	Tue, 26 Jun 2007 22:30:28 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] piix: backport short cables support from ata_piix.c

Bartlomiej Zolnierkiewicz wrote:
> Backport short cables support from ata_piix.c.

> This patch should allow UDMA > 2 modes on:
> - Acer 5602WLMi
> - Acer 3682WLMi
> - Asus W5F
> - Acer Aspire 2023WLMi

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

Acked-by: Sergei Shtylyov <sshtylyov@...mvista.com>

    Minor nit here:

> Index: b/drivers/ide/pci/piix.c
> ===================================================================
> --- a/drivers/ide/pci/piix.c
> +++ b/drivers/ide/pci/piix.c
> @@ -394,12 +394,43 @@ static void piix_dma_clear_irq(ide_drive
[...]
>  static u8 __devinit piix_cable_detect(ide_hwif_t *hwif)
>  {
> -	struct pci_dev *dev = hwif->pci_dev;
> +	struct pci_dev *pdev = hwif->pci_dev;

    Unnecessary rename.

> +	const struct ich_laptop *lap = &ich_laptop[0];

    ... and & and [0] are superfluous with arrays -- they behave like pointers 
in expression.

MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/