[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0706261241130.20744@schroedinger.engr.sgi.com>
Date: Tue, 26 Jun 2007 12:41:54 -0700 (PDT)
From: Christoph Lameter <clameter@....com>
To: Andrew Morton <akpm@...ux-foundation.org>
cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Pekka Enberg <penberg@...helsinki.fi>,
suresh.b.siddha@...el.com
Subject: Re: [patch 15/26] Slab defrag: Support generic defragmentation for
inode slab caches
On Tue, 26 Jun 2007, Andrew Morton wrote:
> This is inverted: __GFP_FS is set if we may perform fs operations.
Sigh.
Slab defragmentation: Only perform slab defrag if __GFP_FS is clear
Avoids slab defragmentation be triggered from filesystem operations.
Signed-off-by: Christoph Lameter <clameter@....com>
---
mm/vmscan.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux-2.6.22-rc4-mm2/mm/vmscan.c
===================================================================
--- linux-2.6.22-rc4-mm2.orig/mm/vmscan.c 2007-06-26 12:25:28.000000000 -0700
+++ linux-2.6.22-rc4-mm2/mm/vmscan.c 2007-06-26 12:40:44.000000000 -0700
@@ -233,8 +233,9 @@ unsigned long shrink_slab(unsigned long
shrinker->nr += total_scan;
}
up_read(&shrinker_rwsem);
- kmem_cache_defrag(sysctl_slab_defrag_ratio,
- zone ? zone_to_nid(zone) : -1);
+ if (gfp_mask & __GFP_FS)
+ kmem_cache_defrag(sysctl_slab_defrag_ratio,
+ zone ? zone_to_nid(zone) : -1);
return ret;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists