linux-kernel - Re: [PATCH 4/5] UML - Simplify helper stack handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070626133550.4a607fe8.akpm@linux-foundation.org>
Date:	Tue, 26 Jun 2007 13:35:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Dike <jdike@...toit.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	uml-devel <user-mode-linux-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 4/5] UML - Simplify helper stack handling

On Thu, 14 Jun 2007 16:26:55 -0400
Jeff Dike <jdike@...toit.com> wrote:

> --- linux-2.6.21-mm.orig/arch/um/drivers/xterm.c	2007-06-13 17:13:42.000000000 -0400
> +++ linux-2.6.21-mm/arch/um/drivers/xterm.c	2007-06-13 18:44:41.000000000 -0400
> @@ -132,7 +132,7 @@ static int xterm_open(int input, int out
>  	}
>  
>  	sprintf(title, data->title, data->device);
> -	pid = run_helper(NULL, NULL, argv, NULL);
> +	pid = run_helper(NULL, NULL, argv);
>  	if (pid < 0) {
>  		err = pid;
>  		printk(UM_KERN_ERR "xterm_open : run_helper failed, "

Something's gone wrong here.  My copy of this file has

        pid = run_helper(NULL, NULL, argv, &stack);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/