linux-kernel - Re: [PATCH -mm] ALSA portman2x4 section mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h3b0dg1fr.wl%tiwai@suse.de>
Date:	Wed, 27 Jun 2007 12:02:32 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>, perex@...e.cz
Subject: Re: [PATCH -mm] ALSA portman2x4 section mismatch

At Tue, 26 Jun 2007 15:30:13 -0700,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> FIx section mismatch when CONFIG_HOTPLUG=n:
> 
> WARNING: sound/built-in.o(.exit.text+0x271): Section mismatch: reference to .init.text:snd_p
> ortman_unregister_all (between 'snd_portman_module_exit' and 'alsa_mpu401_uart_exit')
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

I applied it to ALSA tree now because it's the simplest way to fix
this warning.  But, I'm still wondering whether it was really wrong.

The function snd_portmap_unregister_all() is called both from the
module init and exit functions.  Would the module_exit function be
called even CONFIG_MODULE=n ?  If not, __init_or_module should be
correct since the function is called only from module_init.


thanks,

Takashi


> ---
>  sound/drivers/portman2x4.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.22-rc4-mm2.orig/sound/drivers/portman2x4.c
> +++ linux-2.6.22-rc4-mm2/sound/drivers/portman2x4.c
> @@ -833,7 +833,7 @@ static struct platform_driver snd_portma
>  /*********************************************************************
>   * module init stuff
>   *********************************************************************/
> -static void __init_or_module snd_portman_unregister_all(void)
> +static void snd_portman_unregister_all(void)
>  {
>  	int i;
>  
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/