lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 27 Jun 2007 15:18:07 +0200
From:	Patrick McHardy <>
To:	Vasily Averin <>
	Linux Kernel Mailing List <>,
	Eric Dumazet <>,
	Jan Engelhardt <>,
	"David S. Miller" <>,
Subject: Re: [NETFILTER] early_drop() imrovement (v4)

Vasily Averin wrote:
> Patrick McHardy wrote:
> it is incorrect again: when cnt=0 you should break both cycles.

Indeed, thanks. Fixed now. Also changed it to leave the loop
if we found an entry within a chain (we want the last one of
the chain, so we still walk it entirely) and replaced

hash = (hash + 1) % nf_conntrack_htable_size


hash = (hash + 1) & (nf_conntrack_htable_size - 1)

since one of my queued patches makes sure that its always
a power of two.

View attachment "x" of type "text/plain" (2845 bytes)

Powered by blists - more mailing lists