[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070627145500.2e66fd49@the-village.bc.nu>
Date: Wed, 27 Jun 2007 14:55:00 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Matthew Wilcox <matthew@....cx>
Cc: Matt Domsch <Matt_Domsch@...l.com>,
Randy Dunlap <randy.dunlap@...cle.com>,
lkml <linux-kernel@...r.kernel.org>, gregkh@...e.de,
linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: pci.h stubs (was: EDD build error)
On Wed, 27 Jun 2007 05:30:48 -0600
Matthew Wilcox <matthew@....cx> wrote:
> On Tue, Jun 26, 2007 at 09:45:05PM -0500, Matt Domsch wrote:
> > On Tue, Jun 26, 2007 at 01:26:22PM -0700, Randy Dunlap wrote:
> > > ERROR: "pci_get_bus_and_slot" [drivers/firmware/edd.ko] undefined!
> >
> > It should be stubbed, in include/linux/pci.h where all the other PCI
> > functions are stubbed for the !CONFIG_PCI case.
>
> pci_get_bus_and_slot() shouldn't be used because it fails to work on
> systems with multiple domains. pci_get_slot() avoids this problem (and
> is much faster too).
But requires you have a bus pointer to hand which is often not the
case. Do we need pci_get_domain_bus_and_slot() ?
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists