linux-kernel - Re: [PATCH] trim memory not covered by WB MTRRs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da3e877f0706270722x67bb0738x4274b4367e04f0c6@mail.gmail.com>
Date:	Wed, 27 Jun 2007 14:22:24 +0000
From:	"Mauro Giachero" <mauro.giachero@...il.com>
To:	"Pim Zandbergen" <P.Zandbergen@...roscoop.nl>
Cc:	"Jesse Barnes" <jesse.barnes@...el.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	"Andi Kleen" <andi@...stfloor.org>,
	"Justin Piszcz" <jpiszcz@...idpixels.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Yinghai Lu" <yhlu.kernel@...il.com>
Subject: Re: [PATCH] trim memory not covered by WB MTRRs

On 6/27/07, Pim Zandbergen <P.Zandbergen@...roscoop.nl> wrote:
> Now:
> Jesse released a new patch and I tried if for fun on 2.6.22-rc6
> It looks like the patch is releasing memory rather than trimming it:
>
> [...]
> Jun 27 12:22:56 corneille kernel: **** MTRRs don't cover all of memory,
> trimmed -65536 pages
> [...]

>From Jesse's patch:
> +       unsigned long i, base, size, highest_addr = 0, def, dummy;
> [...]
> +               printk(KERN_WARNING "**** MTRRs don't cover all of "
> +                      "memory, trimmed %ld pages\n", end_pfn -
> +                      (highest_addr >> PAGE_SHIFT));

Since both end_pfn (from arch/x86_64/kernel/e820.c) and highest_addr
are unsigned long, maybe the problem is just that %ld in the kprintf
format string? Shouldn't that be %lu?

Mauro
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/