linux-kernel - Re: pci.h stubs (was: EDD build error)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070627153258.50d5dac3@the-village.bc.nu>
Date:	Wed, 27 Jun 2007 15:32:58 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Matt Domsch <Matt_Domsch@...l.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	lkml <linux-kernel@...r.kernel.org>, gregkh@...e.de,
	linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: pci.h stubs (was: EDD build error)

On Wed, 27 Jun 2007 08:03:05 -0600
Matthew Wilcox <matthew@....cx> wrote:

> On Wed, Jun 27, 2007 at 02:55:00PM +0100, Alan Cox wrote:
> > On Wed, 27 Jun 2007 05:30:48 -0600
> > Matthew Wilcox <matthew@....cx> wrote:
> > > pci_get_bus_and_slot() shouldn't be used because it fails to work on
> > > systems with multiple domains.  pci_get_slot() avoids this problem (and
> > > is much faster too).
> > 
> > But requires you have a bus pointer to hand which is often not the
> > case. Do we need pci_get_domain_bus_and_slot() ?
> 
> We have pci_find_bus(domain, busnr) which will get you the bus pointer.

So the answer is "yes" we should then, and move from pci_get_bus_and_slot
to pci_get_bus_domain_and_slot() [or just add an argument]. The point of
the functions is to be easy to use, so it should be handled internally.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/