linux-kernel - Re: pci.h stubs (was: EDD build error)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070627160756.68c59fff@the-village.bc.nu>
Date:	Wed, 27 Jun 2007 16:07:56 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Matt Domsch <Matt_Domsch@...l.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	lkml <linux-kernel@...r.kernel.org>, gregkh@...e.de,
	linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: pci.h stubs (was: EDD build error)

> > So the answer is "yes" we should then, and move from pci_get_bus_and_slot
> > to pci_get_bus_domain_and_slot() [or just add an argument]. The point of
> > the functions is to be easy to use, so it should be handled internally.
> 
> My point was that code which doesn't currently keep the bus pointer to
> hand should keep the bus pointer to hand instead of the bus number.
> That's easier to use, particularly if you want to actually do any pci
> config accesses.

If you've got the bus pointer yes. If you don't then teaching
pci_get_bus_and_slot() to handle it makes sense.

Another problem here - which bus has the legacy decode mappings ? That
will matter for ATA which also uses pci_get_bus_and_slot...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/