[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LFD.0.98.0706271043570.8675@woody.linux-foundation.org>
Date: Wed, 27 Jun 2007 10:45:55 -0700 (PDT)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Al Viro <viro@....linux.org.uk>
cc: Neil Booth <neil@...kokuya.co.uk>,
Josh Triplett <josh@...edesktop.org>,
Segher Boessenkool <segher@...nel.crashing.org>,
linux-kernel@...r.kernel.org, linux-sparse@...r.kernel.org
Subject: Re: [PATCH 16/16] fix handling of integer constant expressions
On Wed, 27 Jun 2007, Al Viro wrote:
>
> Eh... I'd say that my variant for offsetof() is simply better - it usually
> directly turns into EXPR_VALUE, right in place, without rather convoluted
> work. Aside of "should such cast be a constant integer expression"...
Umm. But sparse is meant to parse C code. Which very much includes *other*
projects.
The kernel, for example, has its own offsetof. And yes, these days we use
"__compiler_offsetof()", but we used to do
#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER)
and I seriously doubt that the kernel is the only one doing things like
that.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists