linux-kernel - Re: [PATCH 4/5] sis5513: backport short cables support from pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200706272115.31807.bzolnier@gmail.com>
Date:	Wed, 27 Jun 2007 21:15:31 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] sis5513: backport short cables support from pata_sis.c

On Tuesday 26 June 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
> 
> > Backport short cables support from pata_sis.c.
> 
> > This patch should allow UDMA > 2 modes on ASUS A6K.
> 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> 
> Acked-by: Sergei Shtylyov <sshtylyov@...mvista.com>
> 
> > Index: b/drivers/ide/pci/sis5513.c
> > ===================================================================
> > --- a/drivers/ide/pci/sis5513.c
> > +++ b/drivers/ide/pci/sis5513.c
> [...]
> > @@ -796,10 +796,33 @@ static unsigned int __devinit init_chips
> >  	return 0;
> >  }
> >  
> > +struct sis_laptop {
> > +	u16 device;
> > +	u16 subvendor;
> > +	u16 subdevice;
> > +};
> > +
> > +static const struct sis_laptop sis_laptop[] = {
> > +	/* devid, subvendor, subdev */
> > +	{ 0x5513, 0x1043, 0x1107 },	/* ASUS A6K */
> > +	/* end marker */
> > +	{ 0, }
> > +};
> > +
> >  static u8 __devinit ata66_sis5513(ide_hwif_t *hwif)
> >  {
> > +	struct pci_dev *pdev = hwif->pci_dev;
> > +	const struct sis_laptop *lap = &sis_laptop[0];
> >  	u8 ata66 = 0;
> >  
> > +	while (lap->device) {
> > +		if (lap->device == pdev->device &&
> > +		    lap->subvendor == pdev->subsystem_vendor &&
> > +		    lap->subdevice == pdev->subsystem_device)
> > +			return ATA_CBL_PATA40_SHORT;
> > +		lap++;
> > +	}
> > +
> 
>    The code even starts looking generic enough to be put into helper...

Hmm, agreed, now if somebody could send me a patch...

Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/