linux-kernel - Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200706281647.57408.arnd@arndb.de>
Date:	Thu, 28 Jun 2007 16:47:55 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	"Zhang Wei-r63237" <Wei.Zhang@...escale.com>
Cc:	linuxppc-dev@...abs.org, mporter@...nel.crashing.org,
	paulus@...ba.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

On Thursday 28 June 2007, Zhang Wei-r63237 wrote:
> > > +static __init int mpc86xx_of_device_init(void)
> > > +{
> > > +       return of_platform_bus_probe(NULL, mpc86xx_of_ids, NULL);
> > > +}
> > 
> > This will add any devices below the "fsl,rapidio-delta" device
> > as an of_device. Is that what you actually want? I would guess that
> > you want to add the bridge itself, not the devices below it.
> > 
> > Is the rapidio device at the root of the device tree, and if so, why
> > not under the soc bus?
> > 
> 
> RapidIO is rather a bus that a device although these is no other nodes defined in its sector now.
> 

That's exactly my point. The meaning of of_platform_bus_probe() is 'add all
direct children of these nodes', not 'add these nodes', although it
happens to do that in the process.

Of course, looking at the device tree, rapidio is a device, not a bus,
because it does not have a device_type and it does not have any children
of its own.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/