linux-kernel - Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070628172514.GA12770@suse.de>
Date:	Thu, 28 Jun 2007 19:25:14 +0200
From:	Stefan Seyfried <seife@...e.de>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Pavel Machek <pavel@....cz>, nigel@...el.suspend2.net,
	linux-kernel@...r.kernel.org, suspend-devel@...ts.sourceforge.net,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

(CC'ing Linus, since disabling consoles during suspend was his idea IIRC)

On Thu, Jun 28, 2007 at 05:34:54PM +0200, Rafael J. Wysocki wrote:
> Hi,
> 
> On Thursday, 28 June 2007 15:51, Pavel Machek wrote:
> > Hi!
> > 
> > What about this? (Only compile tested, but looks pretty obvious to
> > me). Something like this should get us rid of ugly option, and still
> > solve debugging problems... Hmmm?
> > 								Pavel
> > 
> > Kill CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at
> > all, instead, we should automatically keep console alive when
> > possible.
> > 
> > Signed-off-by: Pavel Machek <pavel@...e.cz>
> > 
> > diff --git a/drivers/char/lp.c b/drivers/char/lp.c
> > index 62051f8..8267ff8 100644
> > --- a/drivers/char/lp.c
> > +++ b/drivers/char/lp.c
> > @@ -144,7 +144,7 @@ static unsigned int lp_count = 0;
> >  static struct class *lp_class;
> >  
> >  #ifdef CONFIG_LP_CONSOLE
> > -static struct parport *console_registered; // initially NULL
> > +static struct parport *console_registered;
> >  #endif /* CONFIG_LP_CONSOLE */
> 
> Could you please avoid fixing things like this, white space etc. in this patch?
> It would be easier to read ...

Yes.

> I generally agree with the idea, but the patch needs a clean up, IMHO.

However, we don't know which consoles are safe to stay alive during suspend.
Generally, defaulting to suspending them all is not a bad idea IMHO.
And IIRC it is plain luck if a serial console survives the suspend (or was
the serial code fixed recently?)

So i do not care too much, but my / Frank's patch was shorter :-) and safer.
-- 
Stefan Seyfried
QA / R&D Team Mobile Devices        |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg  | "Well, surrounding them's out." 

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/