linux-kernel - Re: [PATCH] ioremap: fix iounmap numpages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4684FCC9.7010709@goop.org>
Date:	Fri, 29 Jun 2007 08:36:25 -0400
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Dave Young <hidave.darkstar@...il.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Chuck Ebbert <cebbert@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ioremap: fix iounmap numpages

Dave Young wrote:
> Hi,
> The second parameter of change_page_attr in iounmap is wrong, it should be (p->size - 1) >> PAGE_SHIFT
>   

Why's that?  Isn't p->size always going to be a pagesize multiple; in 
which case, why would you want to change_page_attr on n-1 pages?

Are you seeing a problem that this patch fixes?

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/