linux-kernel - Re: [patch] generic bug: use show_regs() instead of dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070629143909.763925e5@dhcp-255-175.norway.atmel.com>
Date:	Fri, 29 Jun 2007 14:39:09 +0200
From:	Haavard Skinnemoen <hskinnemoen@...el.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>, Andi Kleen <ak@...e.de>,
	Kyle McMartin <kyle@...isc-linux.org>,
	Paul Mackerras <paulus@...ba.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] generic bug: use show_regs() instead of dump_stack()

On Fri, 29 Jun 2007 14:19:59 +0200
Heiko Carstens <heiko.carstens@...ibm.com> wrote:

> [patch] generic bug: use show_regs() instead of dump_stack()
> 
> From: Heiko Carstens <heiko.carstens@...ibm.com>
> 
> The current generic bug implementation has a call to dump_stack() in
> case a WARN_ON(whatever) gets hit. Since report_bug(), which calls
> dump_stack(), gets called from an exception handler we can do better:
> just pass the pt_regs structure to report_bug() and pass it to
> show_regs() in case of a warning. This will give more debug informations
> like register contents, etc... In addition this avoids some pointless
> lines that dump_stack() emits, since it includes a stack backtrace of
> the exception handler which is of no interest in case of a warning.
> E.g. on s390 the following lines are currently always present in a stack
> backtrace if dump_stack() gets called from report_bug():
> 
>  [<000000000001517a>] show_trace+0x92/0xe8)
>  [<0000000000015270>] show_stack+0xa0/0xd0
>  [<00000000000152ce>] dump_stack+0x2e/0x3c
>  [<0000000000195450>] report_bug+0x98/0xf8
>  [<0000000000016cc8>] illegal_op+0x1fc/0x21c
>  [<00000000000227d6>] sysc_return+0x0/0x10

I've seen those extra lines on avr32 as well and I agree they are
confusing. Register contents is nice to have too.

Acked-by: Haavard Skinnemoen <hskinnemoen@...el.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/