linux-kernel - Re: [PATCH] frv: fix fallout from "remove sched.h from mm.h" patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0706290904420.13877@localhost.localdomain>
Date:	Fri, 29 Jun 2007 09:10:52 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Alexey Dobriyan <adobriyan@...ru>, dhowells@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] frv: fix fallout from "remove sched.h from mm.h" patch

On Thu, 28 Jun 2007, Andrew Morton wrote:

> On Thu, 28 Jun 2007 18:09:21 +0400
> Alexey Dobriyan <adobriyan@...ru> wrote:
>
> > Signed-off-by: Alexey Dobriyan <adobriyan@...ru>
> > ---
> >
> >  include/asm-frv/pgtable.h |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/include/asm-frv/pgtable.h
> > +++ b/include/asm-frv/pgtable.h
> > @@ -25,7 +25,7 @@
> >  #include <linux/slab.h>
> >  #include <linux/list.h>
> >  #include <linux/spinlock.h>
> > -struct mm_struct;
> > +#include <linux/sched.h>
> >  struct vm_area_struct;
> >  #endif
> >
>
> Please provide changelogs.
>
> I assume this patch fixes some build error or something.

  i actually asked about this on either the janitors or newbies list
the other day -- one of the early examples from the LDD3 device
drivers book which built fine all this time suddenly stopped building,
until i explicitly included <linux/sched.h> to be able to dereference
a pointer to "task_struct":

/home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type
/home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete type

  clearly, until now, that header file was being picked up
*somewhere*, but not now.  so i'm guessing there's going to be code
all over the place that suddenly needs to add that inclusion of
sched.h.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/