linux-kernel - Re: 2.6.22-rc6 spurious hangs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070629141059.GA8995@elte.hu>
Date:	Fri, 29 Jun 2007 16:10:59 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Thomas Sattler <tsattler@....de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Daniel Mack <daniel@...u.de>,
	Holger Waechtler <holger@...u.de>,
	Dmitry Torokhov <dtor@...ightbb.com>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Mariusz Kozlowski <m.kozlowski@...land.pl>,
	v4l-dvb-maintainer@...uxtv.org
Subject: Re: 2.6.22-rc6 spurious hangs


* Oleg Nesterov <oleg@...sign.ru> wrote:

> > > ->disconnect_pending is used without any locks/barriers, perhaps 
> > > this is the reason.
> 
> I misread cinergyt2_release, it checks !->disconnect_pending, so it is 
> very clear why cinergyt2_query_rc() tries to take the mutex.
> 
> > > I'll try to look further tomorrow. In any case, cinergyT2 should not 
> > > use flush_scheduled_work() at all.
> > 
> > would the hack below be worth trying, to see whether there are any 
> > further problems?
[...]
> I don't think we can just kill flush_scheduled_work(). We can use 
> cancel_rearming_delayed_work() instead of 
> cancel_delayed_work()+flush_scheduled_work()
> 
> Still we can't do this under cinergyt2->sem, because cinergyt2_query() 
> takes it too. This all looks very wrong to me, I hope maintaners can 
> explain.

i've Cc:-ed the maintainers.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/