linux-kernel - Re: [PATCH] LinuxPPS (with new syscalls API)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1183134208.1170.366.camel@pmac.infradead.org>
Date:	Fri, 29 Jun 2007 17:23:28 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Rodolfo Giometti <giometti@...eenne.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] LinuxPPS (with new syscalls API) - new version

On Fri, 2007-06-29 at 18:23 +0200, Rodolfo Giometti wrote:
> On Fri, Jun 29, 2007 at 04:41:33PM +0100, David Woodhouse wrote:
> > 
> > <asm-i386/signal.h> includes <linux/time.h>, for some reason.
> > <asm-powerpc/signal.h> doesn't.
> > 
> > You shouldn't rely on <linux/time.h> being pulled in like that -- you
> > either need a forward declaration of struct timespec, or to include
> > <linux/time.h> for yourself from <linux/pps.h>
> 
> Can you please check if this patch resolve your problem?
> 
> diff --git a/include/linux/pps.h b/include/linux/pps.h
> index 6b53864..fe8c645 100644
> --- a/include/linux/pps.h
> +++ b/include/linux/pps.h
> @@ -33,6 +33,7 @@
>  
>  #ifndef __KERNEL__
>  #include <asm/types.h>
> +#include <linux/time.h>
>  #include <sys/time.h>
>  #endif

You'll need to put it in an #else case, not in #ifndef __KERNEL__.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/