linux-kernel - [PATCH] fix logic error in ipc compat semctl()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <46853764.8020608@suse.de>
Date:	Fri, 29 Jun 2007 18:46:28 +0200
From:	Alexander Graf <agraf@...e.de>
To:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: [PATCH] fix logic error in ipc compat semctl()

Hi,

when calling a semctl(IPC_STAT) without IPC_64 the check if the memory
is unevaluated. This patch fixes this.

Signed-off-by: Alexander Graf <agraf@...e.de>

Index: linux/ipc/compat.c
===================================================================
--- linux.orig/ipc/compat.c
+++ linux/ipc/compat.c
@@ -225,7 +225,7 @@ static inline int put_compat_semid_ds(st
        int err;
 
        if (!access_ok (VERIFY_WRITE, up, sizeof(*up)))
-               err = -EFAULT;
+               return -EFAULT;
        err  = __put_compat_ipc_perm(&s->sem_perm, &up->sem_perm);
        err |= __put_user(s->sem_otime, &up->sem_otime);
        err |= __put_user(s->sem_ctime, &up->sem_ctime);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/